Skip to content

tests(e2e): Undo intentional error #7643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2023
Merged

tests(e2e): Undo intentional error #7643

merged 1 commit into from
Mar 29, 2023

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Mar 29, 2023

I accidentally merged an intentional error to ensure the validity of a test causing e2e tests to fail 😬.

(I guess the tests work though, lol)

@lforst lforst requested review from mydea and AbhiPrasad March 29, 2023 11:00
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.62 KB (+0.06% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 64.4 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.16 KB (-0.02% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 56.78 KB (+0.02% 🔺)
@sentry/browser - Webpack (gzipped + minified) 21.53 KB (-0.39% 🔽)
@sentry/browser - Webpack (minified) 72 KB (-0.04% 🔽)
@sentry/react - Webpack (gzipped + minified) 21.55 KB (-0.39% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 51.98 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.16 KB (+0.06% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.36 KB (+0.06% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.74 KB (+0.62% 🔺)
@sentry/replay - Webpack (gzipped + minified) 38.86 KB (+0.83% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 63.41 KB (+0.46% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 56.49 KB (+0.5% 🔺)

@lforst lforst merged commit 9619432 into develop Mar 29, 2023
@lforst lforst deleted the lforst-fix-e2e-tests-by-undoing-manual-error-that-intentionally-lead-e2e-tests-to-fail-lmao branch March 29, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@mydea mydea Awaiting requested review from mydea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lforst @AbhiPrasad